Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the package to an ESM-only distribution, modernizes the TypeScript build output (to dist/ with nodenext), upgrades major dependencies, and switches the test runner from Jest to Vitest while updating CI/publish automation accordingly.
Changes:
- Convert build/packaging to ESM-only (
type: module,exportsupdated,dist/output, remove dual CJS/ESM build). - Upgrade selector/DOM dependency majors and adjust code to updated APIs (
domhandlerisTag,css-select_compileUnsafe, etc.). - Migrate tests and CI from Jest to Vitest; add publish workflow +
SECURITY.md.
Reviewed changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tsconfig.json |
Switch TS output/targets to ESM (es2022, nodenext) and emit to dist/. |
package.json |
Mark package ESM-only, simplify exports, update scripts to Vitest, bump major deps, add Node engine. |
src/index.ts |
Update css-select compilation API and isTag usage; introduce adapter passed to prepareContext. |
src/index.spec.ts |
Update test imports for ESM (.js specifiers) and Vitest. |
src/helpers.spec.ts |
Update test runner imports and ESM .js specifier. |
test/tools/sizzle-testinit.ts |
Update htmlparser2 API usage and isTag import; migrate assertions to Vitest. |
test/sizzle.spec.ts |
Migrate to Vitest, update htmlparser2 API, and swap to domhandler isTag. |
test/advanced-selectors.spec.ts |
Migrate to Vitest and update ESM import path for select. |
.github/workflows/nodejs-test.yml |
Run Vitest instead of Jest; update Node matrix. |
.github/workflows/publish.yml |
Add tag-based publish workflow for npm + JSR with generated jsr.json. |
SECURITY.md |
Add security reporting policy document. |
.gitignore |
Ignore dist/ output and generated jsr.json. |
biome.json |
Bump Biome schema reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bee0f69 to
16aff7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This package is now ESM-only.