fix: remove false-positive cancel warning in AIChatAgent#1290
Merged
threepointone merged 1 commit intomainfrom Apr 11, 2026
Merged
fix: remove false-positive cancel warning in AIChatAgent#1290threepointone merged 1 commit intomainfrom
threepointone merged 1 commit intomainfrom
Conversation
Eliminate duplicate console.warn messages in AIChatAgent when a stream is aborted. The code still marks streams as completed and broadcasts the final chat/text events, but no longer logs the noisy warning about passing options.abortSignal. This reduces log clutter during expected abort flows in packages/ai-chat/src/index.ts.
🦋 Changeset detectedLatest commit: aec62af The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
console.warnabout "Stream was still active when cancel was received" from both_streamSSEReplyand_sendPlaintextReplyabortSignaltostreamText()— because the internal safety-netreader.cancel()always races ahead of the stream's natural terminationContext
When the abort signal fires, our listener immediately calls
reader.cancel(), which resolvesreader.read()with{ done: true }. This is indistinguishable from the stream ending naturally because the user wiredabortSignaltostreamText(). Both produce the same state, so the warning was a false positive in the correctly-wired case.The safety-net
reader.cancel()mechanism (which prevents broadcasting further chunks) is preserved — only the misleading warning is removed.Test plan
cancel-request.test.ts)ws-transport-abort.test.ts)Made with Cursor