Add Process.new with args instead of command, args

[straight-shoota]

Implements part of #14773
See crystal-lang/rfcs#21

[ysbaddaden]

Nice touch to not include the shell argument 👍

Now if we could reduce the duplication between both constructors... Ideally the old one should merely wrap the new one.

[straight-shoota]

We cannot just make it a wrapper because the new one does not support shell feature.
Refactoring to remove duplication is also not easy because it's an initializer and involves instance variable setup. So I opted to leave it at that for now. It's acceptable to have a bit duplication.

[zw963]

Hi, why there is no a ::Process.exec overload which support new format?

            ::Process.exec(
              desired_command.split(" ", remove_empty: true),
              env: environment,
              chdir: @config.root
            )

Error: expected argument #1 to 'Process.exec' to be String, not Array(String)

Overloads are:

• Process.exec(command : String, args : Enumerable(String) | ::Nil = nil, env : Env = nil, clear_env : Bool = false, shell : Bool = false, input : ExecStdio = Redirect::Inherit, output : ExecStdio = Redirect::Inherit, error : ExecStdio = Redirect::Inherit, chdir : Path | String | ::Nil = nil)

---

For now, I use like this:

argv = ::Process.parse_arguments(desired_command)

           ::Process.exec(
             argv[0],
             argv[1..],
             env: environment,
             chdir: @config.root
           )
           ```

[zw963]

One more question, if we are remove shell: true, how to split command like this?

$: cut -d ' ' -f1 1.txt

The expected(correct) result should be:

Process.run(["cut", "-d", " ", "-f1", "1.txt"], output: STDOUT, error: STDOUT)

But, there is no easy way to convert string into correct Array(String), there are so many quirk cases in the shell, finally, user still need use shell frequently like this:

Process.run("/bin/bash", "-c", "cut -d ' ' -f1 1.txt")

[ysbaddaden]

Maybe... do it in Crystal?

File.each_line("1.txt") do |line|
  fields = line.split(' ')
  print fields[1]?
end

Please, discuss on the forum or under issues. This is only indirectly related to this PR. Thanks.

[zw963]

how to split command like this?

okay, never mind, I think the right answer is: ::Process.parse_arguments("cut -d ' ' -f1 1.txt")

This is only indirectly related to this PR

But, ::Process.exec(["ls", "-alh", "/home"]) not related to this PR, right?

Since we already support ::Process.new and ::Process.run, why isn't Process.exec supported?

Should I create a new issue for this?

@straight-shoota @ysbaddaden

[straight-shoota]

Process.exec is not considered in the new API from crystal-lang/rfcs#25 because we're discussing to drop it (see #14422).
When we introduce a portable replacement, it should be expected to follow the new API design.

[zw963]

Just a few of my humble thoughts.

Is anyone else thinking that we're sacrificing too much just for the sake of portability (specifically for Windows？)

In my opinion, if we're running Process.exec on an unsupported platform, it should just raise an error is enough.

[zw963]

Process.exec is not considered in the new API from crystal-lang/rfcs#21 because we're discussing to drop it (see #14422). When we introduce a portable replacement, it should be expected to follow the new API design.

RFC 0021: Percent String Array Literal with Interpolation ？

[straight-shoota]

Sry, it's crystal-lang/rfcs#25