Add arithmetic error reporting for MathInterpreter#16809
Open
kojix2 wants to merge 1 commit intocrystal-lang:masterfrom
Open
Add arithmetic error reporting for MathInterpreter#16809kojix2 wants to merge 1 commit intocrystal-lang:masterfrom
kojix2 wants to merge 1 commit intocrystal-lang:masterfrom
Conversation
ysbaddaden
approved these changes
Apr 7, 2026
| else | ||
| interpret_call_macro(node) | ||
| end | ||
| rescue ex : OverflowError | DivisionByZeroError |
Member
There was a problem hiding this comment.
thought: We should really have a common parent type for these arithmetic error type (cf. #11639).
straight-shoota
approved these changes
Apr 7, 2026
straight-shoota
added
kind:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request attempts to fix #11746.
MathInterpreteris called bySemanticVisitorwhen resolving constant integer values and when interpreting numeric values of Enums. Previously, errors that occurred during operations were not caught, resulting in compiler errors. This pull request adds handling to catchOverflowErrorandDivisionByZeroError.The code was edited with the assistance of the Codex in VSCode Copilot Chat.