Return early on SizeOf-like generic args in non-raising lookup#16811
Open
kojix2 wants to merge 3 commits intocrystal-lang:masterfrom
Open
Return early on SizeOf-like generic args in non-raising lookup#16811kojix2 wants to merge 3 commits intocrystal-lang:masterfrom
kojix2 wants to merge 3 commits intocrystal-lang:masterfrom
Conversation
straight-shoota
added
kind:bug
straight-shoota
approved these changes
Apr 7, 2026
Member
straight-shoota
left a comment
straight-shoota
left a comment
There was a problem hiding this comment.
suggestion: Maybe we should add a comment to these examples that they should not produce an error once #5427 is implemented?
It has been proposed to allow integer expressions and `sizeof()` as part of type notation.(crystal-lang#5427) This reverts commit d172bb3.
Contributor
Author
|
Since the expected behavior has not been agreed on yet, I removed the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
This pull request aims to fix #14731.
It is also a follow-up to #12577.
When
TypeLookup#lookup(node : Generic)runs in type inference,SizeOfand similar nodes in generic arguments should stop the lookup and returnnil. It should not continue to the next argument.If it continues with
next, the generic argument list can become invalid and cause an internal error.This was researched and created with help from GPT-5.4 in VSCode Copilot Chat.