Add smart scope detection for aitools update and uninstall

experimental/aitools/cmd/scope.go

@@ -3,6 +3,7 @@ package aitools
 import (
 	"context"
 	"errors"
+	"fmt"
 	"os"
 	"path/filepath"
 
@@ -15,6 +16,12 @@ import (
 // promptScopeSelection is a package-level var so tests can replace it with a mock.
 var promptScopeSelection = defaultPromptScopeSelection
 
+// promptUpdateScopeSelection is a package-level var for the update scope prompt (3 options: global/project/both).
+var promptUpdateScopeSelection = defaultPromptUpdateScopeSelection
+
+// promptUninstallScopeSelection is a package-level var for the uninstall scope prompt (2 options: global/project).
+var promptUninstallScopeSelection = defaultPromptUninstallScopeSelection
+
 // resolveScope validates --project and --global flags and returns the scope.
 func resolveScope(project, global bool) (string, error) {
 	if project && global {
@@ -72,3 +79,248 @@ func defaultPromptScopeSelection(ctx context.Context) (string, error) {
 
 	return scope, nil
 }
+
+const scopeBoth = "both"
+
+// detectInstalledScopes checks which scopes have a .state.json file present.
+func detectInstalledScopes(globalDir, projectDir string) (global, project bool, err error) {
+	globalState, err := installer.LoadState(globalDir)
+	if err != nil {
+		return false, false, err
+	}
+
+	projectState, err := installer.LoadState(projectDir)
+	if err != nil {
+		return false, false, err
+	}
+
+	return globalState != nil, projectState != nil, nil
+}
+
+// resolveScopeForUpdate resolves scopes for the update command.
+// Returns one or more scopes to update. When both flags are set, global always passes through
+// (for legacy install detection) and project is checked via state.
+func resolveScopeForUpdate(ctx context.Context, projectFlag, globalFlag bool, globalDir, projectDir string) ([]string, error) {
+	hasGlobal, hasProject, err := detectInstalledScopes(globalDir, projectDir)
+	if err != nil {
+		return nil, err
+	}
+
+	if projectFlag && globalFlag {
+		var scopes []string
+		if hasGlobal {
+			scopes = append(scopes, installer.ScopeGlobal)
+		}
+		if hasProject {
+			scopes = append(scopes, installer.ScopeProject)
+		}
+		if len(scopes) == 0 {
+			// Neither installed. Fall through to global for legacy detection.
+			return []string{installer.ScopeGlobal}, nil
+		}
+		return scopes, nil
+	}
+	if projectFlag {
+		return withExplicitScopeCheck(projectDir, installer.ScopeProject, "update", projectDir, hasGlobal, hasProject)
+	}
+	if globalFlag {
+		// Always pass through to the installer layer, which handles legacy installs.
+		return []string{installer.ScopeGlobal}, nil
+	}
+
+	// No flags: auto-detect.
+	switch {
+	case hasGlobal && hasProject:
+		if !cmdio.IsPromptSupported(ctx) {
+			return nil, errors.New("skills are installed in both global and project scopes; use --global, --project, or both flags to specify which to update")
+		}
+		scopes, err := promptUpdateScopeSelection(ctx)
+		if err != nil {
+			return nil, err
+		}
+		return scopes, nil
+
+	case hasGlobal:
+		return []string{installer.ScopeGlobal}, nil
+
+	case hasProject:
+		return []string{installer.ScopeProject}, nil
+
+	default:
+		// Fall through to global scope so the installer layer can detect
+		// legacy installs (skills on disk without .state.json) and provide
+		// appropriate migration guidance.
+		return []string{installer.ScopeGlobal}, nil
+	}
+}
+
+// resolveScopeForUninstall resolves the scope for the uninstall command.
+// Unlike update, uninstall never allows "both" scopes at once.
+func resolveScopeForUninstall(ctx context.Context, projectFlag, globalFlag bool, globalDir, projectDir string) (string, error) {
+	if projectFlag && globalFlag {
+		return "", errors.New("cannot uninstall both scopes at once; run uninstall separately for --global and --project")
+	}
+
+	hasGlobal, hasProject, err := detectInstalledScopes(globalDir, projectDir)
+	if err != nil {
+		return "", err
+	}
+
+	if projectFlag {
+		scopes, err := withExplicitScopeCheck(projectDir, installer.ScopeProject, "uninstall", projectDir, hasGlobal, hasProject)
+		if err != nil {
+			return "", err
+		}
+		return scopes[0], nil
+	}
+	if globalFlag {
+		// Always pass through to the installer layer, which handles legacy installs.
+		return installer.ScopeGlobal, nil
+	}
+
+	// No flags: auto-detect.
+	switch {
+	case hasGlobal && hasProject:
+		if !cmdio.IsPromptSupported(ctx) {
+			return "", errors.New("skills are installed in both global and project scopes; use --global or --project to specify which to uninstall")
+		}
+		scope, err := promptUninstallScopeSelection(ctx)
+		if err != nil {
+			return "", err
+		}
+		return scope, nil
+
+	case hasGlobal:
+		return installer.ScopeGlobal, nil
+
+	case hasProject:
+		return installer.ScopeProject, nil
+
+	default:
+		// Fall through to global scope so the installer layer can detect
+		// legacy installs (skills on disk without .state.json) and provide
+		// appropriate migration guidance.
+		return installer.ScopeGlobal, nil
+	}
+}
+
+// withExplicitScopeCheck validates that the explicitly requested scope has an installation.
+// Returns a helpful error with CWD guidance for project scope and cross-scope hints.
+// The verb parameter (e.g. "update", "uninstall") is used in cross-scope hint messages.
+func withExplicitScopeCheck(dir, scope, verb, projectDir string, hasGlobal, hasProject bool) ([]string, error) {
+	state, err := installer.LoadState(dir)
+	if err != nil {
+		return nil, err
+	}
+	if state == nil {
+		return nil, scopeNotInstalledError(scope, verb, projectDir, hasGlobal, hasProject)
+	}
+
+	return []string{scope}, nil
+}
+
+// scopeNotInstalledError builds a detailed error for when the requested scope has no installation.
+// Includes cross-scope hints when the other scope is installed.
+// The verb parameter (e.g. "update", "uninstall") is used in cross-scope hint messages.
+func scopeNotInstalledError(scope, verb, projectDir string, hasGlobal, hasProject bool) error {
+	var msg string
+	if scope == installer.ScopeProject {
+		expectedPath := filepath.ToSlash(projectDir)
+		msg = fmt.Sprintf(
+			"no project-scoped skills found in the current directory.\n\n"+
+				"Project-scoped skills are detected based on your working directory.\n"+
+				"Make sure you are in the project root where you originally ran\n"+
+				"'databricks experimental aitools install --project'.\n\n"+
+				"Expected location: %s/", expectedPath)
+	} else {
+		msg = "no globally-scoped skills installed. Run 'databricks experimental aitools install --global' to install"
+	}
+
+	hint := crossScopeHint(scope, verb, hasGlobal, hasProject)
+	if hint != "" {
+		msg += "\n\n" + hint
+	}
+
+	return errors.New(msg)
+}
+
+// crossScopeHint returns a hint string if the opposite scope has an installation.
+// The verb parameter (e.g. "update", "uninstall") controls the action in the hint message.
+func crossScopeHint(requestedScope, verb string, hasGlobal, hasProject bool) string {
+	if requestedScope == installer.ScopeProject && hasGlobal {
+		return fmt.Sprintf("Global skills are installed. Run without --project to %s those.", verb)
+	}
+	if requestedScope == installer.ScopeGlobal && hasProject {
+		return fmt.Sprintf("Project-scoped skills are installed. Run without --global to %s those.", verb)
+	}
+	return ""
+}
+
+func defaultPromptUpdateScopeSelection(ctx context.Context) ([]string, error) {
+	homeDir, err := env.UserHomeDir(ctx)
+	if err != nil {
+		return nil, err
+	}
+	globalPath := filepath.Join(homeDir, ".databricks", "aitools", "skills")
+
+	cwd, err := os.Getwd()
+	if err != nil {
+		return nil, err
+	}
+	projectPath := filepath.Join(cwd, ".databricks", "aitools", "skills")
+
+	globalLabel := "Global (" + globalPath + "/)"
+	projectLabel := "Project (" + projectPath + "/)"
+	bothLabel := "Both global and project"
+
+	var scope string
+	err = huh.NewSelect[string]().
+		Title("Which installation should be updated?").
+		Options(
+			huh.NewOption(globalLabel, installer.ScopeGlobal),
+			huh.NewOption(projectLabel, installer.ScopeProject),
+			huh.NewOption(bothLabel, scopeBoth),
+		).
+		Value(&scope).
+		Run()
+	if err != nil {
+		return nil, err
+	}
+
+	if scope == scopeBoth {
+		return []string{installer.ScopeGlobal, installer.ScopeProject}, nil
+	}
+	return []string{scope}, nil
+}
+
+func defaultPromptUninstallScopeSelection(ctx context.Context) (string, error) {
+	homeDir, err := env.UserHomeDir(ctx)
+	if err != nil {
+		return "", err
+	}
+	globalPath := filepath.Join(homeDir, ".databricks", "aitools", "skills")
+
+	cwd, err := os.Getwd()
+	if err != nil {
+		return "", err
+	}
+	projectPath := filepath.Join(cwd, ".databricks", "aitools", "skills")
+
+	globalLabel := "Global (" + globalPath + "/)"
+	projectLabel := "Project (" + projectPath + "/)"
+
+	var scope string
+	err = huh.NewSelect[string]().
+		Title("Which installation should be uninstalled?").
+		Options(
+			huh.NewOption(globalLabel, installer.ScopeGlobal),
+			huh.NewOption(projectLabel, installer.ScopeProject),
+		).
+		Value(&scope).
+		Run()
+	if err != nil {
+		return "", err
+	}
+
+	return scope, nil
+}