Skip to content

perf: inline numeric fast path in array comparison #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
He-Pin wants to merge 1 commit into from
+3 −1
Closed

perf: inline numeric fast path in array comparison #693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sjsonnet/src/sjsonnet/Evaluator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1387,7 +1387,9 @@ class Evaluator(
val yi = y.value(i)
// Reference equality short-circuit for shared array elements
if (!(xi eq yi)) {
// Inline numeric fast path to avoid polymorphic compare() dispatch
// Inline numeric fast path to avoid polymorphic compare() dispatch per element.
// In numeric array comparisons (e.g. 1M elements), this avoids recursive
// method calls with polymorphic dispatch across 5 type branches.
val cmp = xi match {
case xn: Val.Num =>
yi match {
Expand Down
Loading