Fix: Enhance the warning of ntype#7239
Merged
mohanchen merged 3 commits intodeepmodeling:developfrom Apr 14, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves validation and user-facing warnings around ntype by making STRU parsing safer and clarifying how ntype is determined when omitted in INPUT.
Changes:
- Prevent potential out-of-bounds access when checking STRU tokens (
temp.empty()guard before indexing). - Fail fast with a clearer error when no valid
ATOMIC_SPECIESentries can be detected in STRU. - Refine
ntypevalidation: disallow negative values, enforce consistency when explicitly provided, and auto-fill from STRU whenntype == 0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mohanchen
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
Linked Issue
Fix #7229
Unit Tests and/or Case Tests for my changes
What's changed?
Any changes of core modules? (ignore if not applicable)