Fix JDBI named bind params being uppercased and losing spaces in DBeaver SQL formatter#2899
Open
zeepnguyen wants to merge 1 commit intodiffplug:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using JDBI named bind params that collide with SQL keywords (e.g.
:limit,:offset,:set), the DBeaver SQL formatter would incorrectly uppercase them (:limit→:LIMIT) and strip the space before them (LIMIT :limit→LIMIT:limit). Both of these break the resulting SQL.Changes
KEYWORDtoken that is immediately preceded by a:symbol — it's a JDBI named bind param, not a SQL keyword.:when it is preceded by a keyword or name token. Spaces before:are still suppressed when preceded by a symbol (e.g.=:paramremains unchanged).Test
Extended the existing
jdbi-paramstest resource with a query using:limitand:offsetto cover both fixes.