-
Notifications
You must be signed in to change notification settings - Fork 5.8k
fix(publish): detect named volumes with driver_opts bind in checkForBindMount #13702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ishwar170695
wants to merge
4
commits into
docker:main
Choose a base branch
from
ishwar170695:fix/named-volume-driver-opts-bind-check
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+159
−1
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ef314b3
fix(publish): detect named volumes with driver_opts bind in checkForB…
ishwar170695 46b071e
chore: remove accidentally committed scratch file
ishwar170695 ed6ab77
fix: address review comments - preserve volume flags and validate device
ishwar170695 f8b928c
test: add empty device value case to Test_isDriverOptsBind
ishwar170695 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| df5d68b7e919c7b1ab5ff4fcf6514cec7c1c590c fix: update e2e tests to expect exit code 130 on user decline | ||
| Signed-off-by: Ishwar <ishwarcm@iitbhilai.ac.in> | ||
|
|
||
| cbf7940a73f0e0ee8a52d3d30a13054eee46aae4 test: repurpose decline test to cover sensitive data detection path | ||
| Renames test to Test_preChecks_sensitive_data_detected_decline. Uses a temporary .env file with an AWS token to reliably trigger the DefangLabs secret detector, and confirms that preChecks correctly aborts early on user decline. | ||
|
|
||
| Signed-off-by: Ishwar <ishwarcm@iitbhilai.ac.in> | ||
|
|
||
| 61e910218b2b2f0d519058a81d56a307ea2afc73 publish: return ErrPublishAborted when user declines interactive prompts | ||
| Signed-off-by: Ishwar <ishwarcm@iitbhilai.ac.in> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.