Skip to content

Fix 'rbw edit' failure due to client version header #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmlsharp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix 'rbw edit' failure due to client version header #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,6 +812,7 @@ struct FoldersPostReq {
// Used for the Bitwarden-Client-Name header. Accepted values:
// https://github.com/bitwarden/server/blob/main/src/Core/Enums/BitwardenClient.cs
const BITWARDEN_CLIENT: &str = "cli";
const BITWARDEN_CLIENT_VERSION: &str = "2024.12.0";

// DeviceType.LinuxDesktop, as per Bitwarden API device types.
const DEVICE_TYPE: u8 = 8;
Expand Down Expand Up @@ -848,7 +849,7 @@ impl Client {
);
default_headers.insert(
"Bitwarden-Client-Version",
axum::http::HeaderValue::from_static(env!("CARGO_PKG_VERSION")),
axum::http::HeaderValue::from_static(BITWARDEN_CLIENT_VERSION),
);
default_headers.append(
"Device-Type",
Expand Down Expand Up @@ -1159,7 +1160,7 @@ impl Client {
.get(self.api_url("/sync"))
.header("Authorization", format!("Bearer {access_token}"))
// This is necessary for vaultwarden to include the ssh keys in the response
.header("Bitwarden-Client-Version", "2024.12.0")
.header("Bitwarden-Client-Version", BITWARDEN_CLIENT_VERSION)
.send()
.await
.map_err(|source| Error::Reqwest { source })?;
Expand Down Expand Up @@ -1453,6 +1454,7 @@ impl Client {
let res = client
.put(self.api_url(&format!("/ciphers/{id}")))
.header("Authorization", format!("Bearer {access_token}"))
.header("Bitwarden-Client-Version", BITWARDEN_CLIENT_VERSION)
.json(&req)
.send()
.map_err(|source| Error::Reqwest { source })?;
Expand Down
Loading