Skip to content

Add environment variable for profiling EasyBuild #5040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Micket wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add environment variable for profiling EasyBuild #5040

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
069cf56
Add environment variable for profiling easybuild.
Micket Nov 12, 2025
319277a
Fix bash code for passing arguments
Micket Nov 12, 2025
f54e450
Check that at least python 3.9 is used for EB_PROFILE
Micket Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions eb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,22 @@ then
export FANCYLOGGER_IGNORE_MPI4PY=1
fi

# If a profile filename is given, run easybuild via cProfile
if [ -z "${EB_PROFILE}" ]
then
EB_PROFILE_FLAGS=()
else
if [ "${pyver_min}" -lt "9" ]
then
echo "EB_PROFILE not supported for Python < 3.9"
EB_PROFILE=""
Copy link
Copy Markdown
Member

@boegel boegel Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be setting EB_PROFILE_FLAGS, no?

Suggested change
EB_PROFILE=""
EB_PROFILE_FLAGS=()

Copy link
Copy Markdown
Member

@boegel boegel Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Micket ping

Copy link
Copy Markdown
Contributor

@Flamefire Flamefire Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe start with an empty $EB_PROFILE_FLAGS and append/overwrite when required? Gets rid of the first branch and avoids it here.

I'd also make it an error if EB_PROFILE can't be honored.

else
verbose "Writing profile output to: \"${EB_PROFILE}\""
EB_PROFILE_FLAGS=(-m cProfile -o "${EB_PROFILE}")
fi
fi

export EB_SCRIPT_PATH="${0}"

verbose "${PYTHON} -m ${EASYBUILD_MAIN} ${*}"
exec "${PYTHON}" -m "${EASYBUILD_MAIN}" "${@}"
verbose "${PYTHON} ${EB_PROFILE_FLAGS[*]} -m ${EASYBUILD_MAIN} ${*}"
exec "${PYTHON}" "${EB_PROFILE_FLAGS[@]}" -m "${EASYBUILD_MAIN}" "${@}"