Defer use case connection setup until scenario verification (#190, #198)#207
Open
DerAndereAndi wants to merge 1 commit intodevfrom
Open
Defer use case connection setup until scenario verification (#190, #198)#207DerAndereAndi wants to merge 1 commit intodevfrom
DerAndereAndi wants to merge 1 commit intodevfrom
Conversation
Move subscribe/bind/read from entity-added events to an OnScenariosChanged callback that fires once NodeManagementUseCaseData confirms the remote entity actually supports the use case. This prevents cross-triggering between devices running the same use case (e.g. two eg/lpc instances). All HandleEvent data handlers are now gated by IsScenarioAvailableAtEntity so data is only processed for verified use cases. Stale scenarios are cleared when a use case is removed or set unavailable. CS use cases (cs/lpc, cs/lpp) retain binding-driven heartbeat subscription, gated with a scenario check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move subscribe/bind/read from entity-added events to an OnScenariosChanged callback that fires once NodeManagementUseCaseData confirms the remote entity actually supports the use case. This prevents cross-triggering between devices running the same use case (e.g. two eg/lpc instances).
All HandleEvent data handlers are now gated by IsScenarioAvailableAtEntity so data is only processed for verified use cases. Stale scenarios are cleared when a use case is removed or set unavailable.
CS use cases (cs/lpc, cs/lpp) retain binding-driven heartbeat subscription, gated with a scenario check.
Fixes #190 and #198