Add msgCounter to function signature of result callbacks#210
Open
sthelen-enqs wants to merge 1 commit intodevfrom
Open
Add msgCounter to function signature of result callbacks#210sthelen-enqs wants to merge 1 commit intodevfrom
sthelen-enqs wants to merge 1 commit intodevfrom
Conversation
… we can access the msgCounter within the callback function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies usage of the result callback as you can use the msgCounter in the callback to determine which message the response correlates to and don't need to provide that information out-of-band.