Draft
Conversation
This commit introduces breaking changes to accommodate the latest ship-go module updates, featuring the integration of new SHIP Pairing Service.
This commit introduces a rework in the examples to accommodate the SHIP Pairing Service integration. The main change is the retirement of the legacy commandline arguments and the introduction of flags instead.
4a4d579 to
3432d65
Compare
(Service).HasTrustedAddCuDevice() (string, string) changed to (Service).GetTrustedAddCuDevice() *shipapi.ServiceDetails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SHIP Pairing Service Integration
This PR introduces breaking API changes to accommodate the latest ship-go module updates, featuring the integration of the new SHIP Pairing Service.
Core changes:
For example,
RegisterRemoteSKI(ski, shipID string)is migrated toRegisterRemoteService(identity shipapi.ServiceIdentity)pairingConfig: Optional SHIP Pairing configuration. Pass nil if SHIP Pairing should not be used.ringBufferPersistence: Interface to Pairing ring buffer persistence. SHALL be set if pairingConfig is set to listener mode (i.e. devA). See ship-go examples on how to create an implementation of this interface.Examples:
The examples have been updated to accommodate the new API changes.
In addition to that, the legacy commandline arguments have been retired and replaced by flags instead.