Fix CI test to actually use the Postgres database#9954
Draft
browniebroke wants to merge 7 commits intoencode:mainfrom
Draft
Fix CI test to actually use the Postgres database#9954browniebroke wants to merge 7 commits intoencode:mainfrom
browniebroke wants to merge 7 commits intoencode:mainfrom
Conversation
…tent PKs instead of complex URL builders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After merging #9949 I realised that the setup wasn't complete and Postgres tests are in fact skipped:
This is because we run tests with tox and it needs to be instructed to pass environment variables down with the
pass_envoption.Once this was set, the tests started failing with
psycopg.errors.UndefinedTable: relation "auth_user" does not exist, which I fixed by passing--no-migrationsto pytest.Then a number of tests started failing due to hardcoded IDs and ordering assumptions which were no longer true.
Note
This is still a work in progress