Add a new workflow for building the mobile/library/python whl and uploading to pypi#44193
Add a new workflow for building the mobile/library/python whl and uploading to pypi#44193citrus7 wants to merge 15 commits intoenvoyproxy:mainfrom
Conversation
|
Hi @citrus7, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
I've updated this to push to non-test PyPi |
|
you need to fix DCO also - please put this in the existing mobile-release wf - you will need to add an input to select which job to run and conditions on the jobs to enforce that |
Signed-off-by: Jonathan Wu <jtwu@google.com>
Signed-off-by: Jonathan Wu <jtwu@google.com>
Signed-off-by: Jonathan Wu <jtwu@google.com>
|
Thanks for all of the reviews. I've tested the current iteration of the workflow on my personal fork and everything is functional with minimal changes: https://github.com/citrus7/envoy/actions/runs/24145104906/workflow The workflow seems to broken in its current state: https://github.com/envoyproxy/envoy/actions/workflows/mobile-release.yml |
phlax
left a comment
There was a problem hiding this comment.
thanks for iterating - almost there
Signed-off-by: Jonathan Wu <jtwu@google.com>
Signed-off-by: Jonathan Wu <jtwu@google.com>
Signed-off-by: Jonathan Wu <jtwu@google.com>
|
It seems that the mobile/release workflow has been broken for some time due to issue #37218 I took a look at the caching changes and tried to update _load_env.yml to mirror some similar workflows, such as _request.yml in this PR: #44339. @phlax does this look correct to you? I've been able to run this workflow without errors on my fork after these changes, but I'm not sure if the caching itself is functional or doing anything. |
phlax
left a comment
There was a problem hiding this comment.
not totally sure wrt caching and using the default reusable wfs - (ie _mobile_container_ci.yml or _run.yml) - for the reason that they are triggered after a request run and expect to get variables from that
this was one of the reasons that the other wf never got fixed
essentially the benefits are caching and rbe - not sure in this case if that is that important
its possible you could just run this directly with a runs-on rather than using the reuable wfs
Signed-off-by: Jonathan Wu <jtwu@google.com>
Disable Docker caching for the mobile release workflow. Signed-off-by: Jonathan Wu <jtwu@google.com>
Signed-off-by: Jonathan Wu <jtwu@google.com>
|
I've disabled caching and have modified _load_env.yml the minimal amount to make mobile_release.yml functional with no "invalid workflow" errors. |
This reverts commit b2b403e. Signed-off-by: Jonathan Wu <jtwu@google.com>
Remove 'packages: read' permission from mobile release workflow. Signed-off-by: Jonathan Wu <jtwu@google.com>
Signed-off-by: Jonathan Wu <jtwu@google.com>
Create a new workflow that runs on manual dispatch that builds and repairs the mobile/library/python whl and uploads to pypi
Some things that still need work:
The workflow currently only runs on manual dispatch. We could change it to run when changes are made to the //library/python:envoy_mobile_wheel target, but the upload to pypi will fail unless the version is bumped in the BUILD configuration
The workflow is currently still configured for test PyPi. We need to set up an account and credentials for an official PyPi repo and add them to the repository as a secret