envoy_log: allows Envoy version embedding#44337
Open
mathetake wants to merge 3 commits intoenvoyproxy:mainfrom
Open
envoy_log: allows Envoy version embedding#44337mathetake wants to merge 3 commits intoenvoyproxy:mainfrom
mathetake wants to merge 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: envoy_log: allows Envoy version embedding
Additional Description:
We are running multiple Envoy versions on a same VM instance sometimes, so the Envoy's application logs are sometimes interleaved with different Envoy versions, which made it a little bit harder for us to debug later.
This commit adds a new 'E' specifier in the application log to bundle the envoy version in the log line.
Risk Level: low (new code path)
Testing: done
Docs Changes: done
Release Notes: done
Platform Specific Features: n/a