Skip to content

Fix a bug that relates to creating a new instance using self #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
themiscode wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix a bug that relates to creating a new instance using self #6

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab9fcc9
Fix a bug that relates to creating a new instance using self.
themiscode May 8, 2025
137dbf5
Refactor integers to eliminate psalm issues and set php target to 8.
themiscode May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Number/Integer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ final public function getValue(): int
final public static function fromNumeric($value): self
{
if (is_numeric($value)) {
return new self((int)$value);
return new static((int)$value);
}

throw new InvalidArgumentException('Value is not numeric.');
Expand Down
21 changes: 21 additions & 0 deletions tests/Number/NonNegativeIntegerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,25 @@ public function test_isNotEqualToDifferentType(): void
$this->assertFalse($integer1->equals($integer2));
$this->assertFalse($integer2->equals($integer1));
}

public function test_canNotBeCreatedFromNegativeNumericString(): void
{
$this->expectException(InvalidArgumentException::class);

NonNegativeInteger::fromNumeric('-42');
}

public function test_canNotBeCreatedFromNegativeFloat(): void
{
$this->expectException(InvalidArgumentException::class);

$result = NonNegativeInteger::fromNumeric(-42.3);
}

public function test_canNotBeCreatedFromNegativeNumeric(): void
{
$this->expectException(InvalidArgumentException::class);

NonNegativeInteger::fromNumeric(-42);
}
}
28 changes: 28 additions & 0 deletions tests/Number/PositiveIntegerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,32 @@ public function test_isNotEqualToDifferentType(): void
$this->assertFalse($integer1->equals($integer2));
$this->assertFalse($integer2->equals($integer1));
}

public function test_CannotBeCreatedFromNumericZeroString(): void
{
$this->expectException(InvalidArgumentException::class);

PositiveInteger::fromNumeric('0');
}

public function test_CannotBeCreatedFromNumericZeroFloat(): void
{
$this->expectException(InvalidArgumentException::class);

PositiveInteger::fromNumeric(0.0);
}

public function test_CannotBeCreatedFromNumericNegativeIntegerString(): void
{
$this->expectException(InvalidArgumentException::class);

PositiveInteger::fromNumeric('-1');
}

public function test_CannotBeCreatedFromNumericNegativeInteger(): void
{
$this->expectException(InvalidArgumentException::class);

PositiveInteger::fromNumeric(-1);
}
}
Loading