Update version string in MainController when compiling#611
Open
staticssleever668 wants to merge 4 commits intoexch-bms2:masterfrom
Open
Update version string in MainController when compiling#611staticssleever668 wants to merge 4 commits intoexch-bms2:masterfrom
staticssleever668 wants to merge 4 commits intoexch-bms2:masterfrom
Conversation
staticssleever668
force-pushed
the
version_string
branch
from
ba11bbd to
0bd7ed6
Compare
staticssleever668
force-pushed
the
version_string
branch
from
0bd7ed6 to
05cad04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes it so that version string in MainController is set by ant with version defined in build.xml. Now ant's 'make_zip' task creates an archive with proper game version in it's name.
I also added a note in English to MainContoller, which you should probably translate to Japanese.