feat(TimeSmoother): Smoother note falling on vsync mode#835
Open
phu54321 wants to merge 4 commits intoexch-bms2:masterfrom
Open
feat(TimeSmoother): Smoother note falling on vsync mode#835phu54321 wants to merge 4 commits intoexch-bms2:masterfrom
phu54321 wants to merge 4 commits intoexch-bms2:masterfrom
Conversation
Vsync doesn't really ensure evenly timed `MainController::render()` calls. They jitter, and they jitter a lot. More than you'd expect. (You can measure it yourself) This commit adds `TimeSmoother` that *smooths* jittered time when vsync is enabled. If we don't have vsync, It is expected to have frame drops or changes in render() call interval, so `TimeSmoother` is not enabled when vsync is off.
phu54321
changed the title
|
I hope it also applies whether vsync applied or not. capping FPS w/o vsync in beatoraja is also very jittery. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vsync doesn't really ensure evenly timed
MainController::render()calls. They jitter, and they jitter a lot. More than you'd expect. (You can measure it yourself) This commit addsTimeSmootherthat smooths jittered time when vsync is enabled. Smoothed time only takes effect on rendering. The commit does not intend to introduce any in-game internal processings.If we don't have vsync, It is expected to have frame drops or changes in render() call interval, so
TimeSmootheris not enabled when vsync is off.Example video: Right is before, Left if after. Both vsync on 60fps display.
Note that because on current
masterbranch the key input is synchronized torender()call, #829 should be merged for better vsync-ed play experience.