Open
Conversation
pbrubeck
reviewed
Mar 24, 2026
connorjward
commented
Mar 24, 2026
connorjward
commented
Mar 24, 2026
connorjward
commented
Mar 24, 2026
pbrubeck
force-pushed
the
connorjward/default-degree
branch
from
5430eb7 to
c2ec19a
Compare
pbrubeck
force-pushed
the
connorjward/default-degree
branch
from
c2ec19a to
13fb503
Compare
pbrubeck
reviewed
Mar 24, 2026
pbrubeck
reviewed
Mar 24, 2026
pbrubeck
reviewed
Mar 24, 2026
pbrubeck
reviewed
Mar 24, 2026
Co-authored-by: Pablo Brubeck <brubeck@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so that if you pass
degree=Noneto an element you either get a sensible default or it raises aNotImplementedError.Firedrake tests in firedrakeproject/firedrake#4986