Skip to content
Draft
Show file tree
Hide file tree
Changes from 11 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions petsctools/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from .appctx import AppContext # noqa: F401
from .config import ( # noqa: F401
MissingPetscException,
get_config,
Expand Down
154 changes: 154 additions & 0 deletions petsctools/appctx.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,154 @@
import itertools
from functools import cached_property
from petsctools.exceptions import PetscToolsAppctxException


class AppContextKey(int):
"""A custom key type for AppContext."""
pass
Comment thread
JHopeCollins marked this conversation as resolved.
Outdated


class AppContext:
Comment thread
connorjward marked this conversation as resolved.
"""
Class for passing non-primitive types to PETSc python contexts.

The PETSc.Options dictionary can only contain primitive types (str,
int, float, bool) as values. The AppContext allows other types to be
passed into PETSc solvers while still making use of the namespacing
provided by options prefixing.

A typical usage is shown below. In this example we have a python PC
type `MyCustomPC` which requires additional data in the form of a
`MyCustomData` instance.
We can add the data to the AppContext with the `appctx.add` method,
but we need to tell `MyCustomPC` how to retrieve that data. The
`add` method returns a key which is a valid PETSc.Options entry,
i.e. a primitive type instance. This key is passed via PETSc.Options
with the 'custompc_somedata' prefix.

NB: The user should never handle this key directly, it should only
ever be placed directly into the options dictionary.

The data can be retrieved by giving the AppContext the (fully
prefixed) option for the key, in which case the AppContext will
internally fetch the key from the PETSc.Options and return the data.

.. code-block:: python3

appctx = AppContext()
some_data = MyCustomData(5)

opts = OptionsManager(
parameters={
'pc_type': 'python',
'pc_python_type': 'MyCustomPC',
'custompc_somedata': appctx.add(some_data)},
options_prefix='solver')

with opts.inserted_options():
default = MyCustomData(10)
data = appctx.get('solver_custompc_somedata', default)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split this docstring.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create an issue describing what was discussed in the meeting about global options prefixes. I'd have loved to say more but my wifi was terrible!

"""

def __init__(self):
self._count = itertools.count(start=0)
self._data = {}

def _keygen(self):
"""
Generate a new unique internal key.

This should not called directly by the user.
"""
return AppContextKey(next(self._count))

def getKey(self, option):
Comment thread
JHopeCollins marked this conversation as resolved.
Outdated
"""
Return the internal key for the PETSc option `option`.

Parameters
----------
option : str
The PETSc option.

Returns
-------
key : AppContextKey
An internal key corresponding to `option`.
"""
return AppContextKey(self.options_object.getInt(option))

def add(self, val):
"""
Add a value to the application context and
return the autogenerated key for that value.

The autogenerated key should be used as the value for the
corresponding entry in the solver_parameters dictionary.

Parameters
----------
val : Any
The value to add to the AppContext.

Returns
-------
key : AppContextKey
The key to put into the PETSc Options dictionary.
"""
key = self._keygen()
self._data[key] = val
return key

def __getitem__(self, option):
"""
Return the value with the key saved in `PETSc.Options()[option]`.

Parameters
----------
option : Union[str, AppContextKey]
The PETSc option or key.

Returns
-------
val : Any
The value for the key `option`.

Raises
------
PetscToolsAppctxException
If the AppContext does contain a value for `option`.
"""
try:
return self._data[self.getKey(option)]
except KeyError:
raise PetscToolsAppctxException(
f"AppContext does not have an entry for {option}")

def get(self, option, default=None):
"""
Return the value with the key saved in PETSc.Options()[option],
or if it does not exist return default.

Parameters
----------
option : Union[str, AppContextKey]
The PETSc option or key.
default : Any
The value to return if `option` is not in the AppContext

Returns
-------
val : Any
The value for the key `option`, or `default`.
"""
try:
return self[option]
except PetscToolsAppctxException:
return default

@cached_property
def options_object(self):
"""A PETSc.Options instance."""
from petsc4py import PETSc
return PETSc.Options()
4 changes: 4 additions & 0 deletions petsctools/exceptions.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,9 @@ class PetscToolsNotInitialisedException(PetscToolsException):
"""Exception raised when petsctools should have been initialised."""


class PetscToolsAppctxException(PetscToolsException):
"""Exception raised when the Appctx is missing an entry."""


class PetscToolsWarning(UserWarning):
"""Generic base class for petsctools warnings."""
33 changes: 33 additions & 0 deletions tests/test_appctx.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import pytest
import petsctools
from petsctools.exceptions import PetscToolsAppctxException


@pytest.mark.skipnopetsc4py
def test_appctx():
PETSc = petsctools.init()

appctx = petsctools.AppContext()

param = 10
options = PETSc.Options()
options['solver_param'] = appctx.add(param)

# Can we get the key string back?
assert str(appctx.getKey('solver_param')) == options['solver_param']

# Can we access param via the prefixed option?
prm = appctx.get('solver_param')
assert prm is param

prm = appctx['solver_param']
assert prm is param

# Can we set a default value?
default = 20
prm = appctx.get('param', default)
assert prm is default

# Will an invalid key raise an error
with pytest.raises(PetscToolsAppctxException):
appctx['param']