Open
Conversation
…tation, further work on coordination transformation
Rorck
commented
Aug 5, 2025
|
|
||
| override String _serialize(NotExpression expression) '''(«super._serialize(expression)»)''' | ||
|
|
||
| override String _serialize(ImplyExpression expression) '''(«expression.leftOperand.serialize» => «expression.rightOperand.serialize»)''' |
Contributor
Author
There was a problem hiding this comment.
grbeni
requested changes
Feb 3, 2026
Contributor
grbeni
left a comment
grbeni
left a comment
There was a problem hiding this comment.
Left a few comments to address.
...e/hu.bme.mit.gamma.expression.model/src/hu/bme/mit/gamma/expression/util/ExpressionUtil.java
Outdated
Show resolved
Hide resolved
...e/hu.bme.mit.gamma.expression.model/src/hu/bme/mit/gamma/expression/util/ExpressionUtil.java
Outdated
Show resolved
Hide resolved
...nguage/src/hu/bme/mit/gamma/statechart/language/scoping/StatechartLanguageScopeProvider.java
Outdated
Show resolved
Hide resolved
| ; | ||
|
|
||
| SequentialCoordinationReferenceExpression returns SequentialCoordinationReferenceExpression: | ||
| 'seq' '{' instances+=ComponentInstanceReferenceExpression((',') instances+=ComponentInstanceReferenceExpression)* '}' | instances+=ComponentInstanceReferenceExpression |
Contributor
There was a problem hiding this comment.
For the sake of unity, we may (or may not) want to revamp these keywords, e.g., seq -> sequential; we tend to use complete words like transition, state, integer...
...rt.model/src/hu/bme/mit/gamma/statechart/derivedfeatures/StatechartModelDerivedFeatures.java
Outdated
Show resolved
Hide resolved
...ansformation.util/src/hu/bme/mit/gamma/xsts/transformation/serializer/ActionSerializer.xtend
Outdated
Show resolved
Hide resolved
...amma.xsts.transformation/src/hu/bme/mit/gamma/xsts/transformation/ComponentTransformer.xtend
Outdated
Show resolved
Hide resolved
|
|
||
| protected def EqualityExpression createComponentScheduledEqualityExpression(VariableDeclaration scheduledCtrlVar, String name) { | ||
| val enumTypeDefinition = scheduledCtrlVar.typeDefinition as EnumerationTypeDefinition | ||
| return createEqualityExpression(scheduledCtrlVar, createEnumerationLiteralExpression(enumTypeDefinition, name)) |
Contributor
There was a problem hiding this comment.
return scheduledCtrlVar.createEqualityExpression(
createEnumerationLiteralExpression(enumTypeDefinition, name))
...ma.xsts.transformation/src/hu/bme/mit/gamma/xsts/transformation/GammaToXstsTransformer.xtend
Outdated
Show resolved
Hide resolved
...ma.xsts.transformation/src/hu/bme/mit/gamma/xsts/transformation/GammaToXstsTransformer.xtend
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to track the changes related to the Coordination Automata transformation