Add NoOrganizationDropdown component for users with no organization#112475
Draft
Add NoOrganizationDropdown component for users with no organization#112475
Conversation
- Create new NoOrganizationDropdown component that renders when user has no org - Use AvatarButton with Sentry logo as background - Include 'Create a new organization' link in dropdown menu - Update UserOnlyNavigation to use same layout as regular primary nav - Add organization dropdown at top and user settings at bottom - Add comprehensive test coverage for the new component Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
Add organizationUrl and regionUrl to links object in ConfigFixture to match the required type signature. Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
The imported SVG logo was causing runtime errors because webpack loaders return an object, not a string URL. Using letter_avatar with 'Sentry' identifier provides a clean, working solution that displays 'S' as the avatar. Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
Instead of using hidden property which causes empty menus, conditionally build the items array based on feature flags. Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
DropdownMenu renders items with menuitemradio role, not menuitem. Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
NoOrganizationDropdowncomponent that displays when a user has no organization context. The component provides a consistent navigation experience by:AvatarButtonwith the Sentry logo as the backgroundChanges
New Components
NoOrganizationDropdown: A dropdown component that renders when there's no organization in contextAvatarButtonwith Sentry logoorganizations:createfeature flagUpdated Components
UserOnlyNavigation: Updated to use the same layout structure as the regular primary navigationNoOrganizationDropdown) at the top inSidebarHeaderFooterItemsSizeProviderfor consistent sizingTests
NoOrganizationDropdownRelated Context
From Slack discussion in #discuss-design-engineering:
This implements that suggestion by providing a clean, consistent navigation experience for users without an organization.
Testing
All linting checks pass. The component follows Sentry's design system guidelines and uses core components throughout.
Slack Thread