Skip to content

feat(tracemetrics): Bypass metric field validation for equations

4038339
Select commit
Loading
Failed to load commit list.
Merged

feat(tracemetrics): Bypass metric field validation for equations #112479

feat(tracemetrics): Bypass metric field validation for equations
4038339
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden completed Apr 8, 2026 in 1m 11s

1 issue

Medium

TypeError when iterating over None aggregateField - `src/sentry/explore/endpoints/serializers.py:230`

When aggregateField is explicitly None (allowed by allow_null=True on line 115), q.get("aggregateField", []) returns None instead of []. The generator expression then attempts to iterate over None, raising TypeError: 'NoneType' object is not iterable. This will cause a 500 error when saving explore queries with aggregateField: null on the metrics dataset.

2 skills analyzed
Skill Findings Duration Cost
sentry-security 0 1m 1s $0.45
sentry-backend-bugs 1 1m 5s $0.35

Duration: 2m 5s · Tokens: 335.7k in / 5.2k out · Cost: $0.80 (+extraction: $0.00, +fix_gate: $0.00)