Skip to content

ref(grouping): Log example false positive ip data#112487

Merged
lobsterkatie merged 3 commits intomasterfrom
kmclb-log-example-false-positive-ip-data
Apr 8, 2026
Merged

ref(grouping): Log example false positive ip data#112487
lobsterkatie merged 3 commits intomasterfrom
kmclb-log-example-false-positive-ip-data

Conversation

@lobsterkatie
Copy link
Copy Markdown
Member

This adds a new parameterization helper, _log_example_data, which will log the given example data up to a given limit of times per deployment. (The default is 100, but a different limit can be passed in.) It then uses the helper to log examples of our IP false positives.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 8, 2026
@lobsterkatie lobsterkatie force-pushed the kmclb-log-example-false-positive-ip-data branch from 1c0280e to a253de4 Compare April 8, 2026 17:39
@lobsterkatie lobsterkatie marked this pull request as ready for review April 8, 2026 18:59
@lobsterkatie lobsterkatie requested a review from a team as a code owner April 8, 2026 18:59
Copy link
Copy Markdown
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know off the top of my head how many workers we deploy that would touch this code, but just want to double check it's not some extremely high amount, since it'll happen every time we deploy.

An alternative if we're concerned could be to just use a redis rate limiter

@lobsterkatie
Copy link
Copy Markdown
Member Author

lobsterkatie commented Apr 8, 2026

I don't know off the top of my head how many workers we deploy that would touch this code, but just want to double check it's not some extremely high amount, since it'll happen every time we deploy.

An alternative if we're concerned could be to just use a redis rate limiter

If it helps, we only hit the false positive case we're logging in roughly 1 out of every 1000 cases (which is part of the reason I went with a counter rather than a sample rate). Also, I'm only planning to leave this running long enough to harvest a bunch of examples of the phenomenon (depending on how fast they pile up, possibly only a few hours). So I don't think this should end up being a huge number of logs in total. (IDK if that answers your question, but hopefully?)

@lobsterkatie lobsterkatie merged commit 484c71b into master Apr 8, 2026
73 checks passed
@lobsterkatie lobsterkatie deleted the kmclb-log-example-false-positive-ip-data branch April 8, 2026 20:26
@lobsterkatie
Copy link
Copy Markdown
Member Author

UPDATE: Here's the PR doing the removal, when the time comes: #112522.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants