feat(releases): Cache calls to compare-commits #112494
Merged
@sentry/warden / warden
completed
Apr 8, 2026 in 1m 33s
1 issue
High
Variable shadowing causes AttributeError: 'str' object has no attribute 'compare_commits' - `src/sentry/tasks/commits.py:98`
On line 98, provider = repo.provider reassigns the provider parameter to a string (the repository's provider field, e.g., "integrations:github"). Later, lines 120-123 call provider.compare_commits(...) which will fail with AttributeError because strings don't have a compare_commits method. This will crash every call to fetch_compare_commits that results in a cache miss.
Also found at:
src/sentry/tasks/commits.py:247-256
2 skills analyzed
| Skill | Findings | Duration | Cost |
|---|---|---|---|
| sentry-security | 0 | 1m 12s | $0.41 |
| sentry-backend-bugs | 1 | 1m 2s | $0.35 |
Duration: 2m 14s · Tokens: 412.6k in / 7.3k out · Cost: $0.77 (+extraction: $0.00, +merge: $0.00, +fix_gate: $0.00, +dedup: $0.00)
Loading