Integration: Add page for session persistence using Firestore for ADK Java#1563
Integration: Add page for session persistence using Firestore for ADK Java#1563koverholt merged 5 commits intogoogle:mainfrom
Conversation
✅ Deploy Preview for adk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2271995 to
af8f631
Compare
koverholt
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I see that this is based on a pending PR in adk-java (google/adk-java#1096), so we will need to wait for that PR to get reviewed and/or merged/released before we can review and suggest edits on this docs update. I'll mark this as blocked until that happens.
Once that happens, there are a number of issues that need to be addressed in this PR for consistency and formatting, but these can wait until the upstream PR in adk-java is reviewed:
- Use a icon/logo instead of a diagram for catalog icon
- Fix versions throughout and update version tag with corresponding Java version
FirestoreDatabaseRunnerrequiresgcs.adk.bucket.nameto be configured, which is not mentioned- Fill in the Configuration section with actual property names and examples
- Fix the
forecastkey ingetCurrentTime, should betimeor similar - Follow the established integration page structure per Contributing Guide
b967be1 to
4cf1140
Compare
|
Thanks for the great feedback @koverholt ! I can certainly see the value in the information you added.
https://mvnrepository.com/artifact/com.google.adk/google-adk-firestore-session-service
Let me know if you need any further adjustments |
|
Thanks for the updates! Does this functionality depend on google/adk-java#1096 being merged and released? If so, let us know and we will re-review this docs PR when that is ready to test. |
|
thanks for the quick response @koverholt and this functionality is not dependent on https://github.com/google/adk-java/pull/1096 The changes https://github.com/google/adk-java/pull/1096 is about README.md on library component to reflect the latest versions on the example and documentation.. no functional changes |
…sing Firestore database for java adk
4cf1140 to
ac322c3
Compare
|
@koverholt made all the suggested changes and take a look please. |
koverholt
left a comment
There was a problem hiding this comment.
LGTM, thanks for working through the edits! I'll apply a few minor fixes and merge. Thanks again for your contribution to ADK Java and the corresponding docs! ❤️
|
Thanks so much for the thorough review and great feedback, @koverholt ! Also, your turnaround time is seriously impressive. 🚀 |
This is an additional for "Integration"
This commit includes an example and details of Using the Google Cloud Firestore for Session management