cgroupsv2 supports linux.resources.unified from OCI spec#12922
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Open
cgroupsv2 supports linux.resources.unified from OCI spec#12922copybara-service[bot] wants to merge 1 commit intomasterfrom
linux.resources.unified from OCI spec#12922copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
We noticed that setting `linux.resources.unified` to some value, such as `{ "memory.high": "..." }` would work under `runc`, but not under `runsc`. According to the [OCI spec](https://github.com/opencontainers/runtime-spec/blob/main/config-linux.md#unified), `unified` allows us to set any arbitrary cgroupsv2 property.
Whilst the `systemd` driver requires us to [create a mapping](https://github.com/opencontainers/runc/blob/main/docs/systemd.md#cgroup-v2) between known cgroupv2 property labels and the `systemd` equivalent name, for cgroupsv2 this is a trivial change.
FUTURE_COPYBARA_INTEGRATE_REVIEW=#12884 from modal-labs:amit/cgroupv2-unified c395abc
PiperOrigin-RevId: 897940632
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cgroupsv2 supports
linux.resources.unifiedfrom OCI specWe noticed that setting
linux.resources.unifiedto some value, such as{ "memory.high": "..." }would work underrunc, but not underrunsc. According to the OCI spec,unifiedallows us to set any arbitrary cgroupsv2 property.Whilst the
systemddriver requires us to create a mapping between known cgroupv2 property labels and thesystemdequivalent name, for cgroupsv2 this is a trivial change.FUTURE_COPYBARA_INTEGRATE_REVIEW=#12884 from modal-labs:amit/cgroupv2-unified c395abc