Skip to content

Fix typos in gtfs-realtime.proto#541

Open
1Maxnet1 wants to merge 2 commits intogoogle:masterfrom
1Maxnet1:patch-1
Open

Fix typos in gtfs-realtime.proto#541
1Maxnet1 wants to merge 2 commits intogoogle:masterfrom
1Maxnet1:patch-1

Conversation

@1Maxnet1
Copy link
Copy Markdown

@1Maxnet1 1Maxnet1 commented Mar 4, 2025

These only affect the comments therefore should not change the semantics

These only affect the comments therefore should not change the semantics
@google-cla
Copy link
Copy Markdown

google-cla bot commented Mar 4, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 3, 2025

This pull request has been automatically marked as stale because of lack of recent activity. It may be closed manually after one month of inactivity. Thank you for your contributions.

@github-actions github-actions bot added the Status: Stale Issues and Pull Requests that have remained inactive for 30 calendar days or more. label Jun 3, 2025
@eliasmbd eliasmbd added Former Governance Applies This proposal is subject to the former governance process which predates July 7, 2025. and removed Former Governance Applies This proposal is subject to the former governance process which predates July 7, 2025. labels Jul 7, 2025
@github-actions github-actions bot removed the Status: Stale Issues and Pull Requests that have remained inactive for 30 calendar days or more. label Jul 8, 2025
@eliasmbd eliasmbd added Former Governance Applies This proposal is subject to the former governance process which predates July 7, 2025. GTFS Realtime Issues and Pull Requests that focus on GTFS Realtime and removed Former Governance Applies This proposal is subject to the former governance process which predates July 7, 2025. labels Aug 19, 2025
@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because of lack of recent activity. It may be closed manually after one month of inactivity. Thank you for your contributions.

@github-actions github-actions bot added the Status: Stale Issues and Pull Requests that have remained inactive for 30 calendar days or more. label Nov 18, 2025
@github-actions github-actions bot removed the Status: Stale Issues and Pull Requests that have remained inactive for 30 calendar days or more. label Nov 19, 2025
Copy link
Copy Markdown
Contributor

@jfabi jfabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tzujenchanmbd, would this pull request require a vote to merge in?

// When the trip_id corresponds to a non-frequency-based trip, this field
// should either be omitted or be equal to the value in the GTFS feed. When
// the trip_id correponds to a frequency-based trip, the start_time must be
// the trip_id corresponds to a frequency-based trip, the start_time must be
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This same typo is made in reference.md, L489.

message Modification {
// The stop selector of the first stop_time of the original trip that is to be affected by this modification.
// Used in conjuction with `end_stop_selector`.
// Used in conjunction with `end_stop_selector`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This same typo is made in reference.md, L689.

@tzujenchanmbd
Copy link
Copy Markdown
Collaborator

@jfabi Thanks for the reminder!

This appears to be an editorial change.

Governance context:
For changes that do not alter the meaning of the specification, it has been common practice in the community to merge without a vote, even if not explicitly stated in changes.md. This has applied to both gtfs and gtfs-realtime.

On July 2025, the updated gtfs governance explicitly documents the process for editorial changes. However, the gtfs-realtime governance has not yet been updated in the same way.

Based on past practice, I propose proceeding without a vote. If there are no objections, I plan to merge this PR in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GTFS Realtime Issues and Pull Requests that focus on GTFS Realtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants