fix(o11y): use correct Tokio task_local API in RequestRecorder#5293
Closed
haphungw wants to merge 1 commit intogoogleapis:mainfrom
Closed
fix(o11y): use correct Tokio task_local API in RequestRecorder#5293haphungw wants to merge 1 commit intogoogleapis:mainfrom
task_local API in RequestRecorder#5293haphungw wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5293 +/- ##
==========================================
- Coverage 97.75% 97.75% -0.01%
==========================================
Files 215 215
Lines 44904 44904
==========================================
- Hits 43897 43896 -1
- Misses 1007 1008 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
reviewed
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RequestRecorder::current()was usingRECORDER.try_get(), which is not a valid method ontokio::task::LocalKey, causing a compilation error.Surfaced in #5292 when
google_cloud_unstable_tracingis removed.