Skip to content

fix(o11y): use correct Tokio task_local API in RequestRecorder#5293

Closed
haphungw wants to merge 1 commit intogoogleapis:mainfrom
haphungw:fix-recorder
Closed

fix(o11y): use correct Tokio task_local API in RequestRecorder#5293
haphungw wants to merge 1 commit intogoogleapis:mainfrom
haphungw:fix-recorder

Conversation

@haphungw
Copy link
Copy Markdown
Contributor

@haphungw haphungw commented Apr 5, 2026

RequestRecorder::current() was using RECORDER.try_get(), which is not a valid method on tokio::task::LocalKey, causing a compilation error.

Surfaced in #5292 when google_cloud_unstable_tracing is removed.

@haphungw haphungw marked this pull request as ready for review April 5, 2026 17:00
@haphungw haphungw requested a review from a team as a code owner April 5, 2026 17:00
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.75%. Comparing base (10e89c0) to head (e0e0f65).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5293      +/-   ##
==========================================
- Coverage   97.75%   97.75%   -0.01%     
==========================================
  Files         215      215              
  Lines       44904    44904              
==========================================
- Hits        43897    43896       -1     
- Misses       1007     1008       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haphungw haphungw closed this Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants