impl(auth): IAM signer should respect universe domain#5309
Open
alvarowolfx wants to merge 1 commit intogoogleapis:mainfrom
Open
impl(auth): IAM signer should respect universe domain#5309alvarowolfx wants to merge 1 commit intogoogleapis:mainfrom
alvarowolfx wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5309 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 220 220
Lines 45833 45874 +41
=======================================
+ Hits 44818 44860 +42
+ Misses 1015 1014 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbolduc
approved these changes
Apr 8, 2026
| let signer = IamSigner::new( | ||
| "test@example.com".to_string(), | ||
| creds, | ||
| Some("http://example.com".to_string()), |
Member
There was a problem hiding this comment.
nit: can you add a test case where we have a custom endpoint AND the credentials have a custom universe domain?
I know the mock credential's universe domain will be ignored, so it will basically be the same test. Maybe parameterize this for None, Some("custom-universe.com") ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3646