Skip to content

chore: force h2 version to avoid minimal-versions deadlock#5318

Merged
haphungw merged 1 commit intogoogleapis:mainfrom
haphungw:h2-version
Apr 7, 2026
Merged

chore: force h2 version to avoid minimal-versions deadlock#5318
haphungw merged 1 commit intogoogleapis:mainfrom
haphungw:h2-version

Conversation

@haphungw
Copy link
Copy Markdown
Contributor

@haphungw haphungw commented Apr 7, 2026

Fix a gcb-pr-minimal-versions build failure in google-cloud-gax-internal tests caused by h2 version 0.4.2, which surfaces after google_cloud_unstable_tracing guards are removed in #5292.

The Problem
During minimal-versions checks, h2 resolves to 0.4.2, which somehow leads to deadlocks or missing tracing spans in our gRPC tests.

Previous Attempts
I tried switching tests to multi_thread (PR #5308), which masked the issue but was not a good solution.
I tried forcing the version in the root [workspace.dependencies], but Cargo ignored it during the isolated package build for gax-internal.

The Fix
Add h2 = "0.4.13" as a direct dependency in src/gax-internal/Cargo.toml. 0.4.13 is the version resolved in our normal Cargo.lock.

@haphungw haphungw marked this pull request as ready for review April 7, 2026 22:54
@haphungw haphungw requested a review from a team as a code owner April 7, 2026 22:54
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.78%. Comparing base (2e516df) to head (8addd96).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5318      +/-   ##
==========================================
- Coverage   97.79%   97.78%   -0.01%     
==========================================
  Files         220      220              
  Lines       45845    45845              
==========================================
- Hits        44832    44830       -2     
- Misses       1013     1015       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haphungw haphungw changed the title chore(gax-internal): force h2 version to avoid minimal-versions deadlock chore: force h2 version to avoid minimal-versions deadlock Apr 7, 2026
@haphungw haphungw enabled auto-merge (squash) April 7, 2026 22:59
@haphungw haphungw merged commit e373f94 into googleapis:main Apr 7, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants