chore: force h2 version to avoid minimal-versions deadlock#5318
Merged
haphungw merged 1 commit intogoogleapis:mainfrom Apr 7, 2026
Merged
chore: force h2 version to avoid minimal-versions deadlock#5318haphungw merged 1 commit intogoogleapis:mainfrom
h2 version to avoid minimal-versions deadlock#5318haphungw merged 1 commit intogoogleapis:mainfrom
Conversation
coryan
reviewed
Apr 7, 2026
coryan
approved these changes
Apr 7, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5318 +/- ##
==========================================
- Coverage 97.79% 97.78% -0.01%
==========================================
Files 220 220
Lines 45845 45845
==========================================
- Hits 44832 44830 -2
- Misses 1013 1015 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
h2 version to avoid minimal-versions deadlockh2 version to avoid minimal-versions deadlock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a
gcb-pr-minimal-versionsbuild failure ingoogle-cloud-gax-internaltests caused byh2version0.4.2, which surfaces aftergoogle_cloud_unstable_tracingguards are removed in #5292.The Problem
During minimal-versions checks,
h2resolves to0.4.2, which somehow leads to deadlocks or missing tracing spans in our gRPC tests.Previous Attempts
I tried switching tests to
multi_thread(PR #5308), which masked the issue but was not a good solution.I tried forcing the version in the root
[workspace.dependencies], butCargoignored it during the isolated package build forgax-internal.The Fix
Add
h2 = "0.4.13"as a direct dependency insrc/gax-internal/Cargo.toml.0.4.13is the version resolved in our normal Cargo.lock.