perf(spanner): inline BeginTransaction with first query (step 1)#5320
Open
olavloite wants to merge 4 commits intogoogleapis:mainfrom
Open
perf(spanner): inline BeginTransaction with first query (step 1)#5320olavloite wants to merge 4 commits intogoogleapis:mainfrom
olavloite wants to merge 4 commits intogoogleapis:mainfrom
Conversation
Adds support for inlining the BeginTransaction with the first query in a read-only transaction. This saves one round-trip to Spanner for multi-use read-only transactions. This implementation is intentionally simple: 1. It does not support parallel queries at the start of the transaction. 2. It does not include error handling for the first query. 3. It only supports read-only transactions. This is step 1. Follow-up pull requests addresses the above points.
a563896 to
57eb403
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5320 +/- ##
==========================================
+ Coverage 97.79% 97.80% +0.01%
==========================================
Files 220 220
Lines 45845 46066 +221
==========================================
+ Hits 44832 45053 +221
Misses 1013 1013 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbolduc
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for inlining the
BeginTransactionoption with the first query in a read-only transaction. This saves one round-trip to Spanner for multi-use read-only transactions.This implementation is intentionally simple:
This is step 1. Follow-up pull requests addresses the above points.
A preliminary view of the full implementation after all steps can be seen in #5307
See also go/spanner-rust-inline-begin-transaction