refactor(pubsub): use enum for exactly-once message status#5338
Merged
suzmue merged 2 commits intogoogleapis:mainfrom Apr 9, 2026
Merged
refactor(pubsub): use enum for exactly-once message status#5338suzmue merged 2 commits intogoogleapis:mainfrom
suzmue merged 2 commits intogoogleapis:mainfrom
Conversation
Replaces the pending and nacking booleans in ExactlyOnceInfo with a MessageStatus enum. This enforces mutual exclusivity of the states and makes the code more idiomatic. The detailed comments explaining the lease extension behavior for each state have been preserved on the enum variants. Tests have been updated to use the new enum.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5338 +/- ##
==========================================
+ Coverage 97.77% 97.78% +0.01%
==========================================
Files 222 222
Lines 46113 46150 +37
==========================================
+ Hits 45089 45130 +41
+ Misses 1024 1020 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the pending and nacking booleans in ExactlyOnceInfo with a MessageStatus enum. This enforces mutual exclusivity of the states and makes the code more idiomatic.
The detailed comments explaining the lease extension behavior for each state have been preserved on the enum variants. Tests have been updated to use the new enum.
For #5252