feat(sidekick/rust): remove google_cloud_unstable_tracing guards#5103
Draft
haphungw wants to merge 1 commit intogoogleapis:mainfrom
Draft
feat(sidekick/rust): remove google_cloud_unstable_tracing guards#5103haphungw wants to merge 1 commit intogoogleapis:mainfrom
google_cloud_unstable_tracing guards#5103haphungw wants to merge 1 commit intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the google_cloud_unstable_tracing conditional compilation guards from the Rust templates, transitioning the logic to use Mustache template sections. This change simplifies the generated code by removing compile-time feature flags in favor of template-driven generation. A minor consistency issue was identified regarding an unnecessary space in a closing Mustache tag.
haphungw
force-pushed
the
remove-google-cloud-unstable-tracing-guards
branch
from
c729c9f to
a56bb53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
google_cloud_unstable_tracingconditional compilation guards from the Rust templates. This makes tracing unconditionally available in the generated code, subject to runtime configuration viagaxi::options::tracing_enabled.This change prepares for the removal of the unstable feature flag in
google-cloud-rust: google-cloud-rust/pull/5292The submission of this PR is blocked on the turbo launch.