Skip to content

fix(lfs): actually add binaries back to tree#1012

Merged
jounathaen merged 1 commit intohermit-os:mainfrom
n0toose:fix-data-binaries
Jun 25, 2025
Merged

fix(lfs): actually add binaries back to tree#1012
jounathaen merged 1 commit intohermit-os:mainfrom
n0toose:fix-data-binaries

Conversation

@n0toose
Copy link
Copy Markdown
Member

@n0toose n0toose commented Jun 24, 2025

Fixes #1011

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.87%. Comparing base (232ca55) to head (c30c1ce).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1012   +/-   ##
=======================================
  Coverage   73.87%   73.87%           
=======================================
  Files          28       28           
  Lines        3173     3173           
=======================================
  Hits         2344     2344           
  Misses        829      829           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@n0toose
Copy link
Copy Markdown
Member Author

n0toose commented Jun 24, 2025

P.S. Zero idea how this went past the CI earlier. I don't like computers.

@n0toose n0toose mentioned this pull request Jun 24, 2025
@mkroening
Copy link
Copy Markdown
Member

Zero idea how this went past the CI earlier. I don't like computers.

That's because our self-hosted runners are dirty. On GitHub-hosted runners (#748), CI now fails as expected.

@n0toose
Copy link
Copy Markdown
Member Author

n0toose commented Jun 24, 2025

Yeah, hope that the fix I pushed is good enough for now - I'll try to break main less often.

Sorry about that, had a pretty chaotic last week. 😅

@jounathaen
Copy link
Copy Markdown
Member

I don't like and more importantly don't understand git lfs. Let's hope that this one gets rid of it finally.

@jounathaen jounathaen added this pull request to the merge queue Jun 25, 2025
Merged via the queue into hermit-os:main with commit f7a1a1a Jun 25, 2025
10 checks passed
@jounathaen jounathaen deleted the fix-data-binaries branch June 25, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.gitattributes is missing from main branch

4 participants