-
Notifications
You must be signed in to change notification settings - Fork 31
Document process of updating test images & update test images #1168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
n0toose
wants to merge
1
commit into
hermit-os:main
Choose a base branch
from
n0toose:update-data-images
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # Uhyve `data/` directory | ||
|
|
||
| This directory contains example unikernels and configurations that can be used with Uhyve. | ||
|
|
||
| - `uhyve.toml`: Example configuration file for Uhyve, also used in unit tests. | ||
| - `x86_64`: Sample unikernel images compiled for `x86_64`. | ||
| - `aarch64`: Sample unikernel images compiled for `aarch64`. | ||
|
|
||
| The `x86_64` unikernel images are used for CI tests. | ||
|
|
||
| ## Sample unikernels | ||
|
|
||
| The unikernels under `tests/test-kernels` are continuously compiled against the latest release of the [Hermit kernel]. They aim to provide test coverage for how the kernel "reacts" to the behavior of unikernels. | ||
|
|
||
| In contrast, the unikernels under `data` are prebuilt binaries that are intended as "demos". The CI uses them to test runtime parameters such as `--stats` or `--file-isolation`. They are "older" on purpose; only to be updated only if a major, backwards incompatible change in the kernel takes place. Implicitly, they also test Uhyve's backwards compatibility with older versions of the kernel (that may, in turn, rely upon an older version of `uhyve-interface` as well). | ||
|
|
||
| ### Updating the sample unikernels | ||
|
|
||
| The images are built from the examples of the [hermit-rs repository]. | ||
|
|
||
| <insert concrete steps here> | ||
|
|
||
| For reproducibility reasons, we include the **permalink** to the source code used to compile the binary, as well as the toolchain version that we used. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think adding the permalink here is a little overkill. Mentioning the toolchain in the commit of the update is more than sufficient. |
||
|
|
||
| ### Unikernel image list | ||
|
|
||
| | File | Link | Toolchain version | | ||
| | ------------------------- | --------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------- | | ||
| | `data/x86_64/hello_world` | https://github.com/hermit-os/hermit-rs/tree/996086ee72178d0d463be20a5ce22a6daf81666f/examples/hello_world | rust version 1.93.0-nightly (2286e5d22 2025-11-13) (`nightly-x86_64-unknown-linux-gnu`) | | ||
| | `data/x86_64/rusty_demo` | https://github.com/hermit-os/hermit-rs/tree/996086ee72178d0d463be20a5ce22a6daf81666f/examples/demo | rust version 1.93.0-nightly (2286e5d22 2025-11-13) (`nightly-x86_64-unknown-linux-gnu`) | | ||
| | `data/x86_64/hello_c` | | | | ||
| | `data/aarch64/hello_world`| https://github.com/hermit-os/hermit-rs/tree/996086ee72178d0d463be20a5ce22a6daf81666f/examples/demo | rust version 1.93.0-nightly (2286e5d22 2025-11-13) (`nightly-x86_64-unknown-linux-gnu`) | | ||
|
|
||
| [Hermit kernel]: https://github.com/hermit-os/kernel | ||
| [hermit-rs repository]: https://github.com/hermit-os/hermit-rs | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this as a comment to track the addition of the steps