Use vm_memory crate instead of in-house#1199
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1199 +/- ##
==========================================
+ Coverage 76.82% 77.57% +0.75%
==========================================
Files 26 26
Lines 3667 3675 +8
==========================================
+ Hits 2817 2851 +34
+ Misses 850 824 -26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e6b711f to
e458d49
Compare
fogti
left a comment
There was a problem hiding this comment.
Having three address types for guest addresses certainly makes stuff more confusing... Would it be possible to get rid of one?
Yeah. I really hate it. But the vm_memory crate uses a different type than the kernel. So we can't use the same type in uhyve-interface without changing it in the kernel, and I would rather not include a new dependency in the kernel just for the type alias, and the current address type is "better" than the vm_memory one. |
|
re: my proposal of the |
3f495ad to
4c563c2
Compare
|
@fogti So now I've changed this PR so that we still use our |
dd6db09 to
8501cc5
Compare
|
It does solve the issue with the address types. |
4a1d2eb to
3c8c590
Compare
58ae306 to
f763ee4
Compare
|
That are a lot of force pushes... |
|
May the force be with me... I guess this is ready now? |
Co-authored-by: Bader Zaidan <bader.zaidan@rwth-aachen.de>
All should be implemented by now. As we can still improve stuff later, let's merge it!
Extracted from #643
Honestly, I'm not a 100% fan of this, but we need this in order to use vmm-mem's virtqueue abstractions in #643