Conversation
fogti
added
enhancement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1296 +/- ##
==========================================
- Coverage 76.72% 75.45% -1.27%
==========================================
Files 29 29
Lines 4266 4356 +90
==========================================
+ Hits 3273 3287 +14
- Misses 993 1069 +76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fogti
force-pushed
the
hermit-image-intern
branch
from
5ebe71d to
f4967e0
Compare
| libc::mprotect( | ||
| &mut mem_slice[0] as *mut u8 as *mut libc::c_void, | ||
| aligned_image_len, | ||
| libc::PROT_READ | libc::PROT_EXEC, |
There was a problem hiding this comment.
Albeit the kernel should under no circumstances try to write to the image, afaik we shouldn't prohibit it from executing parts of it (e.g. libraries).
| } | ||
| } | ||
|
|
||
| /// Specify the way an Hermit image should be provided to the Hermit Kernel |
There was a problem hiding this comment.
| /// Specify the way an Hermit image should be provided to the Hermit Kernel | |
| /// Specify the way an Hermit image should be handled by Uhyve. |
|
|
||
| /// Let the Hermit kernel handle the Hermit image provision. | ||
| /// | ||
| /// This should be faster on average, but requires an Hermit kernel that supports it. |
There was a problem hiding this comment.
| /// This should be faster on average, but requires an Hermit kernel that supports it. | |
| /// This should be faster on average, but requires an Hermit kernel that supports it and reduces the effective memory of the kernel. |
| // insert Hermit image tree into file map | ||
| file_mapping.add_hermit_image(&buf_decompressed[..])?; | ||
| } | ||
| use crate::params::HermitImageMode; |
There was a problem hiding this comment.
The use can also go to the top of the file, right?
jounathaen
left a comment
jounathaen
left a comment
There was a problem hiding this comment.
Looks very good. Just a few nitpicks from my side
|
btw. the only reason why I used the It might be a good idea to get rid of it basically everywhere (tho particularly when used as struct field names and such). |
fogti
force-pushed
the
hermit-image-intern
branch
from
f4967e0 to
b24f56f
Compare
2 participants
Unfortunately, as there is no working Hermit Kernel side implementation yet, this can't be tested yet.
This is the Uhyve counterpart to hermit-os/loader#511.