Add riscv64 build, make Linux wheel build matrix more explicit#77
Open
threexc wants to merge 2 commits intohuggingface:mainfrom
Open
Add riscv64 build, make Linux wheel build matrix more explicit#77threexc wants to merge 2 commits intohuggingface:mainfrom
threexc wants to merge 2 commits intohuggingface:mainfrom
Conversation
For Linux builds, distinguish between 'target' and 'arch', since the two are not always the same (e.g. the target for ppc64le is actually powerpc64le-unknown-linux-gnu). This allows more explicit support for other platforms when needed. Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Note that the 'target' and 'arch' values here are different - arch is riscv64, but the actual rustc target is riscv64gc-unknown-linux-gnu, hence the previous change. Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Author
|
Ping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maturin supports riscv64 cross build, but the arch string and the target toolchain for rustc don't exactly match up (this is also the case for other architectures like ppc64le and x86). To make the riscv64 addition consistent with the others, change the platform list so that arch and target are distinct fields.
Note that this is being done on behalf of the RISE Project to improve Python ecosystem support on riscv64 platforms.