fix: correctly handle empty scheme in trino backend connect#11908
Closed
veeceey wants to merge 1 commit intoibis-project:mainfrom
Closed
fix: correctly handle empty scheme in trino backend connect#11908veeceey wants to merge 1 commit intoibis-project:mainfrom
veeceey wants to merge 1 commit intoibis-project:mainfrom
Conversation
The walrus operator in the auth string check was evaluating to False when urlparse(host).scheme returned an empty string, preventing BasicAuthentication from being set up correctly. Changed to explicitly check 'is not None' to handle hosts without scheme prefixes. Fixes ibis-project#11841
Member
|
This looks like an LLM-generated PR that's a duplicate of #11842 anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11841
The walrus operator in the auth string check was evaluating to False when
urlparse(host).schemereturned an empty string, preventingBasicAuthenticationfrom being set up correctly when usinghttp_schemeparameter with hosts that don't have a scheme prefix.Changes
and (scheme := urlparse(host).scheme)toand (scheme := urlparse(host).scheme) is not NoneTest Plan