feat(duckdb): Add support for reading and writing Vortex files#11980
Open
AdamGS wants to merge 1 commit intoibis-project:mainfrom
Open
feat(duckdb): Add support for reading and writing Vortex files#11980AdamGS wants to merge 1 commit intoibis-project:mainfrom
AdamGS wants to merge 1 commit intoibis-project:mainfrom
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR adds support for reading and writing Vortex files through the DuckDB backend, where its been a core extension since version 1.4.2.
I've added a callout to the relevant docstrings as as far as I can tell there's no established mechanism to signal that here. I've also marked both functions as experimental (seems like for Parquet
to_parquetis experimental butto_parquetisn't, figured its worth being cautions here).I've considered merging support for both formats into a single private function, but there are subtle differences in the API even in basic cases - Vortex accepts only a single path/glob while parquet can accept many.