Skip to content

Add an asByteArrayAsync method taking promise for Content.Source#13939

Merged
lachlan-roberts merged 3 commits intojetty-12.1.xfrom
fix/jetty-12.1.x/ContentSourceAsByteArray
Nov 7, 2025
Merged

Add an asByteArrayAsync method taking promise for Content.Source#13939
lachlan-roberts merged 3 commits intojetty-12.1.xfrom
fix/jetty-12.1.x/ContentSourceAsByteArray

Conversation

@lachlan-roberts
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
Comment thread jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/Content.java Outdated
Comment thread jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/Content.java Outdated
Copy link
Copy Markdown
Contributor

@lorban lorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides @sbordet 's review, this looks good but what's the justification for this extra helper?

Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
@lachlan-roberts
Copy link
Copy Markdown
Contributor Author

@lorban in GoogleCloudPlatform/functions-framework-java#333 a method required that the request body be read into a byte array, so Simone suggested that this helper method should be added back to Jetty with the Promise API considering the CompletableFuture one was deprecated with no replacement.

@lachlan-roberts lachlan-roberts added the Sponsored This issue affects a user with a commercial support agreement label Nov 5, 2025
@lachlan-roberts lachlan-roberts merged commit 229ffd4 into jetty-12.1.x Nov 7, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Jetty 12.1.4 - FROZEN Nov 7, 2025
@lachlan-roberts lachlan-roberts deleted the fix/jetty-12.1.x/ContentSourceAsByteArray branch November 7, 2025 05:40
lorban pushed a commit that referenced this pull request Jan 21, 2026
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Sponsored This issue affects a user with a commercial support agreement

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants