fix(langgraph): merge callbacks in ensure_config instead of overwriting#7424
Open
ccurme (ccurme) wants to merge 3 commits intomainfrom
Open
fix(langgraph): merge callbacks in ensure_config instead of overwriting#7424ccurme (ccurme) wants to merge 3 commits intomainfrom
ensure_config instead of overwriting#7424ccurme (ccurme) wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ensure_configused last-write-wins for thecallbackskey, which caused callbacks set via.with_config()to be silently dropped when a later config also contained callbacks. This affectedastream_events(and thereforestream_mode="events", which injects its own internal callback handler), overwriting any user-provided callbacks onself.config.Here we update
ensure_configto merge callbacks using the same logic as inmerge_configs.