Swc migration by YASHMAHAKAL · Pull Request #26 · layer5io/mui-datatables

YASHMAHAKAL · 2026-02-17T12:49:25Z

Notes for Reviewers

This PR fixes #

Migrates from Babel to SWC

Signed commits

Yes, I signed my commits.

YASHMAHAKAL · 2026-02-17T13:06:35Z

@leecalcote should i also upgrade mocha version ? please take a look

saurabhraghuvanshii · 2026-02-17T13:18:43Z

package.json

  "scripts": {
    "dev": "cross-env NODE_ENV=development webpack-dev-server -d --progress --colors",
-    "test": "cross-env NODE_ENV=test mocha --require ./test/babel-register.js --extensions js,jsx test/**/*.test.js",
+    "test": "cross-env NODE_ENV=test mocha --require ./test/swc-register.js --extension js --extension jsx test/**/*.test.js",


@YASHMAHAKAL two times --extension flag, why?

@saurabhraghuvanshii instead of the comma-separated values, i just added it twice, it matches mocha's current cli behavior

kishore08-07

@YASHMAHAKAL I noticed inconsistent module configurations across files: .swcrc and .swcrc.test are using commonjs, while rollup.config.js is configured for es6.
Could we align these configs or rely on Rollup to handle the module format to avoid potential build inconsistencies?

kishore08-07 · 2026-02-19T17:33:12Z

package.json

@@ -107,7 +97,6 @@
  "dependencies": {
    "@babel/runtime-corejs3": "^7.12.1",


@YASHMAHAKAL @babel/runtime-corejs3 is still in dependencies. Can we remove this?

@kishore08-07, i had a reason for this, but i thought on that reason again, and now i think i should be removing it, Thanks.

kishore08-07 · 2026-02-19T17:33:29Z

rollup.config.js

+        targets: {
+          ie: '11',
+          chrome: '58',
+          firefox: '54',
+          safari: '10',
+          edge: '15',


@YASHMAHAKAL shall we update to modern baselines?

implemented, this made build even faster.. Thanks !

YASHMAHAKAL · 2026-02-19T17:59:47Z

@YASHMAHAKAL I noticed inconsistent module configurations across files: .swcrc and .swcrc.test are using commonjs, while rollup.config.js is configured for es6. Could we align these configs or rely on Rollup to handle the module format to avoid potential build inconsistencies?

The different module types are intentional and follow the recommended pattern for Rollup + SWC.
The .swcrc commonjs is used by @swc-node/register in Node.js tests, node requires CommonJS.
Inside the Rollup plugin, we use es6 so rollup can perform static analysis and tree-shaking on es module import/export statements. If we set it to commonjs, SWC would convert imports to require() calls before rollup sees them, which would break rollup's tree shaking entirely.

kishore08-07 · 2026-02-19T18:44:47Z

@YASHMAHAKAL I noticed inconsistent module configurations across files: .swcrc and .swcrc.test are using commonjs, while rollup.config.js is configured for es6. Could we align these configs or rely on Rollup to handle the module format to avoid potential build inconsistencies?

The different module types are intentional and follow the recommended pattern for Rollup + SWC. The .swcrc commonjs is used by @swc-node/register in Node.js tests, node requires CommonJS. Inside the Rollup plugin, we use es6 so rollup can perform static analysis and tree-shaking on es module import/export statements. If we set it to commonjs, SWC would convert imports to require() calls before rollup sees them, which would break rollup's tree shaking entirely.

@YASHMAHAKAL Thanks for clarifying, that makes sense.

leecalcote · 2026-03-24T01:58:32Z

@saurabhraghuvanshii keep working this through, please.

saurabhraghuvanshii · 2026-03-24T18:32:01Z

@YASHMAHAKAL, did you test your changes? Did you see any improvement in build time?

YASHMAHAKAL · 2026-03-24T18:33:18Z

@saurabhraghuvanshii yes, build time was reduced to 900 ms vs 2.5 seconds

YASHMAHAKAL · 2026-03-24T18:33:57Z

@saurabhraghuvanshii however, i just resolved merge conflicts so i'm testing it again

saurabhraghuvanshii · 2026-03-24T18:42:09Z

@saurabhraghuvanshii yes, build time was reduced to 900 ms vs 2.5 seconds

Wow!!

YASHMAHAKAL · 2026-03-24T19:13:33Z

@saurabhraghuvanshii i have tested it again and new build time is - 1.2 seconds vs 4.5 seconds after having changes in master recently : )

Rajesh-Nagarajan-11

Looks Good to me

saurabhraghuvanshii · 2026-03-25T09:41:02Z

.eslintrc

  "settings": {
    "react": {
-      "version": "latest"
+      "version": "detect"


@YASHMAHAKAL I don't think we need this!

@saurabhraghuvanshii makes sense but i used detect because it's recommended one, and latest forces linter to use it's newest ruleset regardless our package.json.
However if you think otherwise i will revert it, Thanks !

@YASHMAHAKAL revert this keep only logical change.

Done @saurabhraghuvanshii !

Rajesh-Nagarajan-11 · 2026-03-25T09:44:52Z

@YASHMAHAKAL did you test all the scripts that are mentioned in package.json especially ( npm run dev & npm run build ) ?

YASHMAHAKAL · 2026-03-25T09:50:16Z

@YASHMAHAKAL did you test all the scripts that are mentioned in package.json especially ( npm run dev & npm run build ) ?

yes @Rajesh-Nagarajan-11

Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>

YASHMAHAKAL · 2026-04-08T17:39:50Z

@saurabhraghuvanshii take a look again, i've made the fix

github-actions bot added area/challenges area/learning-paths labels Feb 17, 2026

saurabhraghuvanshii reviewed Feb 17, 2026

View reviewed changes

leecalcote requested review from Rajesh-Nagarajan-11, kishore08-07 and matrixkavi February 19, 2026 15:40

kishore08-07 suggested changes Feb 19, 2026

View reviewed changes

YASHMAHAKAL requested a review from kishore08-07 February 19, 2026 19:05

YASHMAHAKAL force-pushed the swc-migration branch from 4c3f9b3 to 4cc37ff Compare March 24, 2026 18:22

Rajesh-Nagarajan-11 approved these changes Mar 25, 2026

View reviewed changes

saurabhraghuvanshii reviewed Mar 25, 2026

View reviewed changes

YASHMAHAKAL added 6 commits March 30, 2026 20:22

initial migration

064fd0c

Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>

remove @babel/runtime-corejs3 dependency

ce6f2f5

Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>

replaced 8-line IE11-era object with MUI v7 query string

669e7c4

Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>

removed mui/emotions

17cc3f0

Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>

removed babel parser

7dbf1cb

Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>

revert .eslintrc

e2ca3dc

Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>

rishiraj38 approved these changes Apr 7, 2026

View reviewed changes

update rollup config

a58174f

Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>

YASHMAHAKAL force-pushed the swc-migration branch from a2948a4 to a58174f Compare April 8, 2026 17:37

YASHMAHAKAL requested a review from saurabhraghuvanshii April 8, 2026 17:39

YASHMAHAKAL requested a review from Rajesh-Nagarajan-11 April 8, 2026 17:43

		@@ -107,7 +97,6 @@
		"dependencies": {
		"@babel/runtime-corejs3": "^7.12.1",

Conversation

YASHMAHAKAL commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YASHMAHAKAL commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YASHMAHAKAL Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kishore08-07 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YASHMAHAKAL commented Feb 19, 2026

Uh oh!

kishore08-07 commented Feb 19, 2026

Uh oh!

leecalcote commented Mar 24, 2026

Uh oh!

saurabhraghuvanshii commented Mar 24, 2026

Uh oh!

YASHMAHAKAL commented Mar 24, 2026

Uh oh!

YASHMAHAKAL commented Mar 24, 2026

Uh oh!

saurabhraghuvanshii commented Mar 24, 2026

Uh oh!

YASHMAHAKAL commented Mar 24, 2026

Uh oh!

Rajesh-Nagarajan-11 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rajesh-Nagarajan-11 commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YASHMAHAKAL commented Mar 25, 2026

Uh oh!

YASHMAHAKAL commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

YASHMAHAKAL commented Feb 17, 2026 •

edited

Loading

YASHMAHAKAL commented Feb 17, 2026 •

edited

Loading

YASHMAHAKAL Feb 17, 2026 •

edited

Loading

Rajesh-Nagarajan-11 commented Mar 25, 2026 •

edited

Loading