Fix Blaze folding flux:error as static hidden HTML in inline field templates#2564
Open
joshhanley wants to merge 2 commits intomainfrom
Open
Fix Blaze folding flux:error as static hidden HTML in inline field templates#2564joshhanley wants to merge 2 commits intomainfrom
flux:error as static hidden HTML in inline field templates#2564joshhanley wants to merge 2 commits intomainfrom
Conversation
The `flux:error` component inside `with-inline-field` and `with-reversed-inline-field` was rendered directly within a `@blaze(fold: true)` block. When Blaze is installed, this causes the error div to be folded at compile time with a null name, permanently hiding validation errors for checkboxes, radios, and switches. This applies the same `@unblaze` pattern already used in `with-field.blade.php`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Scenario
When Blaze is installed, validation errors on
flux:checkbox,flux:radio, andflux:switchnever render. The errordivis folded as static hidden HTML at compile time and never re-evaluated at runtime.The Problem
with-inline-field.blade.phpandwith-reversed-inline-field.blade.phprenderflux:errordirectly inside a@blaze(fold: true)block without wrapping it in@unblaze.with-field.blade.phpalready handles this correctly.The Solution
Wrap
flux:errorin@unblazein bothwith-inline-field.blade.phpandwith-reversed-inline-field.blade.php, matching the existing pattern inwith-field.blade.php.Fixes #2560