Fix issue with plugin loader for typescript files#2030
Merged
jwoertink merged 2 commits intoluckyframework:mainfrom Apr 3, 2026
Merged
Conversation
When plugins process a file, they tell Bun what kind of file it is. The code was always saying "this is a JS file" regardless of the actual file type, iven if it matched the js/jsx/ts/tsx regex. So when Bun received a TypeScript file, it tried to prase it as plain JavaScript and choked on type annotations like : string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #2029
Description
When plugins process a file, they tell Bun what kind of file it is. The code was always saying "this is a JS file" regardless of the actual file type, given if it matched the js/jsx/ts/tsx regex. So when Bun received a TypeScript file, it tried to parse it as plain JavaScript and choked on type annotations like : string.
Checklist
crystal tool format spec src./script/setup./script/test