Implement attribute setting for PeriodicSite to route through propert…#18
Open
cogsworth37 wants to merge 1 commit intomaterialsproject:mainfrom
Open
Implement attribute setting for PeriodicSite to route through propert…#18cogsworth37 wants to merge 1 commit intomaterialsproject:mainfrom
cogsworth37 wants to merge 1 commit intomaterialsproject:mainfrom
Conversation
…ies, ensuring persistence across serialization and structure sorting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ies, ensuring persistence across serialization and structure sorting.
Summary
Major changes:
fixes materialsproject/pymatgen#2339
Checklist
ruff.mypy.duecredit@due.dcitedecorators to reference relevant papers by DOI (example)Tip: Install
pre-commithooks to auto-check types and linting before every commit: